Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Addon pko doc #14

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Addon pko doc #14

wants to merge 4 commits into from

Conversation

venkateshsredhat
Copy link

No description provided.


## Tenants Onboarding Steps

Team's can generate the packageImage themselves using the [package operator documentation](https://package-operator.run/docs/guides/packaging-an-application/#build--validate) or Team's can use Managed Tenants Bundles (MTB) facilities.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Team's can generate the packageImage themselves using the [package operator documentation](https://package-operator.run/docs/guides/packaging-an-application/#build--validate) or Team's can use Managed Tenants Bundles (MTB) facilities.
Teams can generate the packageImage themselves using the [package operator documentation](https://package-operator.run/docs/guides/packaging-an-application/#build--validate) or teams can use Managed Tenants Bundles (MTB) facilities.


## Tenants Onboarding Steps

Team's can generate the packageImage themselves using the [package operator documentation](https://package-operator.run/docs/guides/packaging-an-application/#build--validate) or Team's can use Managed Tenants Bundles (MTB) facilities.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Team's can generate the packageImage themselves using the [package operator documentation](https://package-operator.run/docs/guides/packaging-an-application/#build--validate) or Team's can use Managed Tenants Bundles (MTB) facilities.
Teams can generate the packageImage themselves using the [package operator documentation](https://package-operator.run/docs/guides/packaging-an-application/#build--validate) or teams can use Managed Tenants Bundles (MTB) facilities.


Team's can generate the packageImage themselves using the [package operator documentation](https://package-operator.run/docs/guides/packaging-an-application/#build--validate) or Team's can use Managed Tenants Bundles (MTB) facilities.

Below are the Steps for generating the packageImage using MTB for reference-addon packageImage :
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Below are the Steps for generating the packageImage using MTB for reference-addon packageImage :
Below are the Steps for generating the packageImage using MTB for reference-addon packageImage:

In MTB, a Team just have to create a "package" directory:
https://gitlab.cee.redhat.com/service/managed-tenants-bundles/-/tree/main/addons/reference-addon/package and add the manifests there, alongside the manifests.yaml[PackageManifest] .

MTB CI will create the packageImage (in addition to the OLM Index Image which are also part of the Team's addon folder https://gitlab.cee.redhat.com/service/managed-tenants-bundles/-/tree/main/addons/reference-addon ) .
Copy link
Contributor

@garrettthomaskth garrettthomaskth Jun 26, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
MTB CI will create the packageImage (in addition to the OLM Index Image which are also part of the Team's addon folder https://gitlab.cee.redhat.com/service/managed-tenants-bundles/-/tree/main/addons/reference-addon ) .
MTB CI will create the packageImage (in addition to the OLM Index Image which is also part of the Team's addon folder https://gitlab.cee.redhat.com/service/managed-tenants-bundles/-/tree/main/addons/reference-addon) .

Based on review
@venkateshsredhat
Copy link
Author

@garrettthomaskth could you take a look now ?


MTB CI will create the packageImage (in addition to the OLM Index Image which is also part of the Team's addon folder https://gitlab.cee.redhat.com/service/managed-tenants-bundles/-/tree/main/addons/reference-addon) .

The last step for the team is to raise a MR to [managed-tenants repository](https://gitlab.cee.redhat.com/service/managed-tenants/-/blob/main/addons/reference-addon/addonimagesets/stage/reference-addon.v0.10.1.yaml#L24) , adding a new AddonImageSet with those images.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you're using MTB, this step of creating the MT with the AddonImageSet is also automated.

I'd reccomend action using the MTB flow, that will help with documenting the steps.


MTB CI will create the packageImage (in addition to the OLM Index Image which is also part of the Team's addon folder https://gitlab.cee.redhat.com/service/managed-tenants-bundles/-/tree/main/addons/reference-addon) .

Then MTB CI raises a MR to [managed-tenants repository](https://gitlab.cee.redhat.com/service/managed-tenants/-/blob/main/addons/reference-addon/addonimagesets/stage/reference-addon.v0.10.1.yaml#L24) , adding a new AddonImageSet with those images.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can write something like, Once the MTB Pr is merged and builds are successful a MR is generated...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants