Added a method to get run dates in a date range #41
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
getRangeRunDates returns all run dates limited to a date range.
max(0, $total) doesn't need to be calculated in every iteration.
| /** | ||
| * Get ALL run dates limited to a date range | ||
| * | ||
| * @param string|DateTime $start Start of range |
There was a problem hiding this comment.
null|string|DateTime, same for line below
|
Fixed input type in comments. Thanks @staabm |
|
I like this feature. Can you add tests please? |
| $guard = $this->getNextRunDate($start, 0, true); | ||
| $guard <= $end; | ||
| $guard = $this->getNextRunDate($guard, 0, false) | ||
| ) |
There was a problem hiding this comment.
Can you add braces here? I don't like blocks without a wrapping brace
"cleaner code" by re aligning some comments and adding braces.
|
@mtdowling I will add tests too but with a couple of days delay. Sorry for that but it is my finals' week at school. |
Open
|
This is a really needed functionality. |
peter279k
pushed a commit
to peter279k/cron-expression
that referenced
this pull request
Nov 25, 2020
…able Support DateTimeImmutable
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added a method to get run dates in a date range and some minor optimizations.