Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: pre-commit hook #37

Merged
merged 10 commits into from
Feb 16, 2024
Merged

Feature: pre-commit hook #37

merged 10 commits into from
Feb 16, 2024

Conversation

muandane
Copy link
Owner

@muandane muandane commented Feb 5, 2024

Fixes #

Proposed Changes

  1. trying to add pre-commit hook

Readiness Checklist

Author/Contributor

  • Add entry to the CHANGELOG listing the change and linking to the corresponding issue (if appropriate)
  • If documentation is needed for this change, has that been included in this pull request

Reviewing Maintainer

  • Label as breaking if this is a large fundamental change
  • Label as either automation, bug, documentation, enhancement, infrastructure, or performance

@muandane muandane force-pushed the feat/pre-commit-hook branch from 586e954 to 07225e4 Compare February 8, 2024 19:07
Copy link

codecov bot commented Feb 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (3fac165) 38.94% compared to head (eff36e8) 38.94%.
Report is 3 commits behind head on main.

❗ Current head eff36e8 differs from pull request most recent head 190c66d. Consider uploading reports for the commit 190c66d to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #37   +/-   ##
=======================================
  Coverage   38.94%   38.94%           
=======================================
  Files           4        4           
  Lines         208      208           
=======================================
  Hits           81       81           
  Misses        117      117           
  Partials       10       10           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@muandane muandane force-pushed the feat/pre-commit-hook branch from 21bf2ec to eff36e8 Compare February 16, 2024 18:20
feat: goji-check pre-commit hook
test: testing hook

test: testing hook

test: testing hook
Signed-off-by: moualhi zine el abidine <[email protected]>

need to add doc comment

feat ✨: using script instead of language and removal of stages

Signed-off-by: moualhi zine el abidine <[email protected]>
need to add doc comment

need to add doc comment

need to add doc comment

need to add doc comment
Signed-off-by: moualhi zine el abidine <[email protected]>

feat ✨: dddssa a asda s

fix 🐛 (djdj ): ddjjas asdasd a
fail commit

fix 🐛(test): disabling otel collector

fix 🐛(test): fixed check commit to work in pre-commit hook setting

Signed-off-by: moualhi zine el abidine <[email protected]>
Signed-off-by: moualhi zine el abidine <[email protected]>
Signed-off-by: moualhi zine el abidine <[email protected]>
@muandane muandane force-pushed the feat/pre-commit-hook branch from eff36e8 to 190c66d Compare February 16, 2024 18:21
@muandane muandane merged commit 9d1bba4 into main Feb 16, 2024
1 check passed
@muandane muandane deleted the feat/pre-commit-hook branch February 16, 2024 18:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant