Bugfix: Always add delay to currentTime. #150
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…he past when first noteOn wasn't run straight away after loading MIDI.js
| @@ -323,4 +317,4 @@ | |||
| return new (window.AudioContext || window.webkitAudioContext)(); | |||
There was a problem hiding this comment.
Please merge this bugfix into mainstream. I was trying to play Javascript generated melodies with MIDI.js and it took me 1 hour just to find this bug, which prevents MIDI.js to work correctly, so this bug-report must be accepted.
|
As I argued in #168 (comment), I think that the better solution would be to never add |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It used to set first notes in the past when first noteOn wasn't run straight away after loading MIDI.js