Updating uglify version and polyfill concat paths. #183
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jensechu
changed the title
| 'inc/polyfill/Base64.js', | ||
| 'inc/polyfill/base64binary.js' | ||
| 'inc/shim/Base64.js', | ||
| 'inc/shim/base64binary.js' |
There was a problem hiding this comment.
I had to change this to
Suggested change
| 'inc/shim/base64binary.js' | |
| 'inc/shim/Base64binary.js' |
(Mind the capitalization.)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hallo!
I was trying to play around with this awesome project but ran into a few issues so I figured to do the neighborly thing and fork your repo!
When I was running
npm installeverything was peachy, but when runninggruntI was getting this error:Warnings: Cannot assign to read only property 'subarray' .... After some researching I realized it was just because thegrunt-contrib-uglifypackage wasn't updated.I also noticed that in the
concatgrunt task that it is trying to concat:inc/polyfill/Base64.jsinc/polyfill/base64binary.jsbut concat fails silently and does not end up including these files because they truly live in
inc/shim/which was giving me an error when actually trying to use MIDI.js in the browser.When I updated the paths to
inc/shim/everything was great! 😸I hope this seems legit to you. 🙇