Improve Soundfont generation #258
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Issue explained at PatrickWolleb/SoundFontJS#1 (comment) Added SOX dependency
Small fix to the sox command
It was found that midilib uses names that are incompatible with MIDI.js For example, midilib uses "SynthBrass 1" -> https://github.com/jimm/midilib/blob/6c8e481ae72cd9f00a38eb3700ddfca6b549f153/lib/midilib/consts.rb#L280 and the MIDI association uses "SynthBrass 1" -> https://www.midi.org/specifications-old/item/gm-level-1-sound-set but the MIDI.js calls this "Synth Brass 1" -> https://github.com/mudcube/MIDI.js/blob/a8a84257afa70721ae462448048a87301fc1554a/js/midi/gm.js#L44 there are others like "Bag pipe" vs "Bagpipe", etc. here, we use the MIDI.js definitions because that is how most users will interact with the generated soundfonts.
MIDI.js uses a `clean` function to turn human readable names into slugs for instrument names. This PR makes the builder's names match that of MIDI.js https://github.com/mudcube/MIDI.js/blob/a8a84257afa70721ae462448048a87301fc1554a/js/midi/gm.js#L11
Update to the FatBoy soundfont, which is free (https://fatboy.site/)
|
As far as I know the project has been abandoned. I have a fork at https://github.com/mscuthbert/midicube which is taking PRs. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR performs two main goals:
midilibnaming schemes.For example,
midilibuses "SynthBrass 1" -> https://github.com/jimm/midilib/blob/6c8e481ae72cd9f00a38eb3700ddfca6b549f153/lib/midilib/consts.rb#L280and the MIDI association uses "SynthBrass 1" -> https://www.midi.org/specifications-old/item/gm-level-1-sound-set
but the MIDI.js calls this "Synth Brass 1" ->
MIDI.js/js/midi/gm.js
Line 44 in a8a8425
There are others like "Bag pipe" vs "Bagpipe" that cause issues with generation.
Now we use the MIDI.js definitions because that is how most users will interact with the generated soundfonts.