OUTDATED: http/middleware directory, request middleware centralization, model list filtering
#2698
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ctional changes Signed-off-by: Dave Lee <[email protected]>
✅ Deploy Preview for localai ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Signed-off-by: Dave Lee <[email protected]>
Signed-off-by: Dave Lee <[email protected]>
Signed-off-by: Dave Lee <[email protected]>
dave-gray101
requested review from
mudler,
sozercan and
cryptk
and removed request for
mudler
Signed-off-by: Dave Lee <[email protected]>
Signed-off-by: Dave Lee <[email protected]>
Signed-off-by: Dave Lee <[email protected]>
Signed-off-by: Dave Lee <[email protected]>
Signed-off-by: Dave Lee <[email protected]>
Signed-off-by: Dave Lee <[email protected]>
Signed-off-by: Dave Lee <[email protected]>
Signed-off-by: Dave Lee <[email protected]>
Signed-off-by: Dave Lee <[email protected]>
Signed-off-by: Dave Lee <[email protected]>
Signed-off-by: Dave Lee <[email protected]>
auto-merge was automatically disabled
July 5, 2024 19:54
Pull Request is not mergeable
dave-gray101
changed the title
http/middleware directory, request middleware centralization, model list filteringhttp/middleware directory, request middleware centralization, model list filtering
auto-merge was automatically disabled
October 12, 2024 23:02
Pull request was closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Middleware Refactor
This PR has a few goals, but is scoped strictly to avoid major functional changes:
core/http/middlewareto hold http related code that's not endpoint specific--
metrics.gois pure file movement to live with the others.--
auth.gohandles the creation ofkeyauthconfiguration data and contains the validation function.--- actual implementation of auth has been temporarily moved to my keyauth v2 backport - I submitted and merged the required feature changes to fiber upstream, but v3 is not quite yet stable enough for us to target... hence this backport.
--
request.gocontains a series of composable middlewares that are able to either extract user-provided information from the fiber context, or provide programmer suggested defaults. Later on, endpoints can retrieve these from fiber context Locals.Applicationcontainer to endpoints as needed. This is subject to future change as more services are createdListModelsandBackendConfigto add filtering capabilities, currently mostly used for setting defaults, but also drives some UI elements now.-- Currently reserved for the next PR but may end up here - plan to add a checkbox to UI to determine if "loose files" should appear in the dropdowns or not.