Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: ListModels Filtering Upgrade #2773

Open
wants to merge 46 commits into
base: master
Choose a base branch
from

Conversation

dave-gray101
Copy link
Collaborator

Description

This PR introduces just the ListModels and config package changes from my earlier middleware PR. In order to manage size and conflicts, this PR does not use Usecase-based filtering yet - simply migrates existing name based filtering to the new style and sets up the initial test to prove usecases are working.

In the upcoming [new] middleware PR, default models will take this into account and we can drive better dropdowns on the UI as well.

@dave-gray101 dave-gray101 requested a review from mudler July 11, 2024 18:51
Copy link

netlify bot commented Jul 11, 2024

Deploy Preview for localai ready!

Name Link
🔨 Latest commit 2e8c010
🔍 Latest deploy log https://app.netlify.com/sites/localai/deploys/66e9e70b8eb91f00080260d2
😎 Deploy Preview https://deploy-preview-2773--localai.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@dave-gray101 dave-gray101 enabled auto-merge (squash) July 11, 2024 19:12
@dave-gray101 dave-gray101 changed the title groundwork: ListModels Filtering Upgrade refactoring: groundwork: ListModels Filtering Upgrade Jul 12, 2024
@dave-gray101 dave-gray101 changed the title refactoring: groundwork: ListModels Filtering Upgrade refactoring: groundwork - ListModels Filtering Upgrade Jul 12, 2024
@dave-gray101 dave-gray101 changed the title refactoring: groundwork - ListModels Filtering Upgrade refactor: groundwork: ListModels Filtering Upgrade Jul 12, 2024
@dave-gray101 dave-gray101 changed the title refactor: groundwork: ListModels Filtering Upgrade refactor: groundwork - ListModels Filtering Upgrade Jul 12, 2024
@dave-gray101 dave-gray101 changed the title refactor: groundwork - ListModels Filtering Upgrade refactor: ListModels Filtering Upgrade Jul 12, 2024
@dave-gray101
Copy link
Collaborator Author

@mudler I just updated this for the new SoundGeneration endpoint. It's ready for review whenever you get a chance - should have no effects on current behavior, just sets groundwork and introduces a test for a heuristic Usecase function we can use to drive dropdowns and suggest better "defaults"

Signed-off-by: Dave Lee <[email protected]>
@dave-gray101
Copy link
Collaborator Author

force push seems to have fixed DCO - hopefully it doesn't snag again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant