Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: allow setting trust_remote_code for sentencetransformers backend #3552

Merged

Conversation

Nyralei
Copy link
Contributor

@Nyralei Nyralei commented Sep 16, 2024

Description
Allow setting trust_remote_code for SentenceTransformers backend for loading models such as nvidia/NV-Embed-v2 as described in issue: #3544

This PR fixes #3544

Notes for Reviewers
Added datasets and einops to requirements because nvidia/NV-Embed-v2 asked for it on loading.

Signed commits

  • Yes, I signed my commits.

Copy link

netlify bot commented Sep 16, 2024

Deploy Preview for localai ready!

Name Link
🔨 Latest commit 0dab566
🔍 Latest deploy log https://app.netlify.com/sites/localai/deploys/66e868f5fcc56200084f0307
😎 Deploy Preview https://deploy-preview-3552--localai.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@Nyralei Nyralei changed the title Allow setting trust_remote_code for SentenceTransformers backend feat: allow setting trust_remote_code for sentencetransformers backend Sep 16, 2024
@Nyralei Nyralei force-pushed the sentencetransformers-trust-remote-code branch from 203657e to 0dab566 Compare September 16, 2024 17:20
Copy link
Collaborator

@dave-gray101 dave-gray101 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Thanks for the fix!

While TrustRemoteCode should be used with caution, it should be plumbed through to the backend.

@dave-gray101 dave-gray101 enabled auto-merge (squash) September 17, 2024 03:16
@dave-gray101 dave-gray101 merged commit 4a4e44b into mudler:master Sep 17, 2024
31 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cannot Load an Embedding model
2 participants