-
-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Centralized Request Processing middleware #3847
Open
dave-gray101
wants to merge
8
commits into
mudler:master
Choose a base branch
from
dave-gray101:feat-request-middleware
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for localai ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
dave-gray101
force-pushed
the
feat-request-middleware
branch
from
October 16, 2024 22:51
ed7f03e
to
7dfddc7
Compare
1 task
dave-gray101
force-pushed
the
feat-request-middleware
branch
from
October 24, 2024 02:46
13a7411
to
85ed9ae
Compare
1 task
|
1 task
dave-gray101
force-pushed
the
feat-request-middleware
branch
from
December 17, 2024 00:04
d077bae
to
a55011e
Compare
Signed-off-by: Dave Lee <[email protected]>
dave-gray101
force-pushed
the
feat-request-middleware
branch
from
December 17, 2024 20:06
df37c12
to
d08311f
Compare
@mudler Ready for review, now with working VAD test. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR reworks how our endpoints parse and process user input, in order to centralize and commonize that code as much as possible. This will drastically cut down the endpoint-specific code to a minimum.
Additionally, the VAD subsystem was untested - making it hard to validate if this changeset was safe or not. Therefore, this PR also adds both manual testing tools (via bruno) and automated testing in the AIO image.
Note to @mudler - this PR looks worse than it is - here's some reviewing notes to help
core/http/middleware/request.go
should be where you start - its the heart of the change and replacescore/http/ctx/fiber.go
LOCALAI_SINGLE_ACTIVE_BACKEND=true
helps with a memory usage issue!