unpack local file bundle #318
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mudler
reviewed
Feb 2, 2023
| if err != nil { | ||
| return nil, err | ||
| var err error | ||
| if strings.HasPrefix(local, filePrefix) { |
There was a problem hiding this comment.
This is looking good! I think it's safe to just check the input for the file suffix. No need to specify --local at that point
There was a problem hiding this comment.
updated.
DownloadAndExtractDockerImage will be called only if it's !local && !strings.HasPrefix(image, filePrefix)
rest of the cases - ExtractDockerImage will be called.
mudler
requested changes
Feb 2, 2023
santhoshdaivajna
force-pushed
the
unpack_local_image
branch
from
11df83d to
7956938
Compare
|
care to add a small unit test? I'm trying to fix the CI in #319 meanwhile |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
issue : 317
take image file path as an input and extract the content to destination path.
ex: luet util unpack file://home/us/alpine.tar /tmp --local