+56
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
metacode22
requested review from
hyesungoh,
sjoleee,
Seojunhwan,
sangbooom,
Orchemi,
sumi-0011,
100Gyeon and
WooWan
as code owners
sangbooom
approved these changes
Nov 12, 2024
Comment on lines
+295
to
+305
| ```typescript | ||
| const queryClient = new QueryClient({ | ||
| queryCache: new QueryCache({ | ||
| onError: (error) => { | ||
| ... | ||
| }, | ||
| }), | ||
| }); | ||
| ``` | ||
|
|
||
| > 요런 친구도 중재자 패턴이라고 할 수 있을까요? 하위 ErrorBoundary에서 걸러지지 않은 에러들은 이렇게 최상위의 query client에서 처리해주고 있는디. |
There was a problem hiding this comment.
제 생각엔 퍼사드 패턴 같아요!
QueryClient가 퍼사드 역할을 하고 내부적으로는 QueryCache와 다른 요소들이 함께 작동한다는 점이 퍼사드 패턴이지 않을까 생각이 드네요 🤔
There was a problem hiding this comment.
둘 다 아닐까요?
QueryClient라는 중재자를 두어 에러처리를 중앙에서 처리하니까 개별 컴포넌트간의 의존성과 결합도를 낮출 수 있는거고, onError같은 핸들러는 복잡한 구현을 숨기고 사용성이 좋은 인터페이스만 노출하니까 퍼사드라고 볼 수 있을 것 같아요
hyesungoh
approved these changes
Nov 13, 2024
Comment on lines
+266
to
+268
|
|
||
| > [디자인패턴, Flyweight Pattern, 플라이 웨이트 패턴](https://www.youtube.com/watch?v=oRThakO5o-Q) 이 영상의 예시가 조금 더 쉬워서 이해하기 수월했어요. | ||
|
|
Comment on lines
+295
to
+305
| ```typescript | ||
| const queryClient = new QueryClient({ | ||
| queryCache: new QueryCache({ | ||
| onError: (error) => { | ||
| ... | ||
| }, | ||
| }), | ||
| }); | ||
| ``` | ||
|
|
||
| > 요런 친구도 중재자 패턴이라고 할 수 있을까요? 하위 ErrorBoundary에서 걸러지지 않은 에러들은 이렇게 최상위의 query client에서 처리해주고 있는디. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
허허.. 이해는 잘 안되네요. 어렵구만유