-
-
Notifications
You must be signed in to change notification settings - Fork 310
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add prop sidebarCollapsed and onToggleSidebar #4514
Conversation
I'm wondering if we should maintain the convention of naming a controlled prop "xyz" + "onXyzChange". edit: actually, it looks like the data grid has the convention of "xyzOpen", "onXyzOpen" and "onXyzClose". Perhaps that's the closest in spirit? |
@Janpot Are you suggesting to have two different callbacks for open and close events? Also can you help me with pointing out why some of the checks are failing? |
|
I ran that command before raising the PR. What I have noticed is this lines props are wrongly generated. Correct proptype should be
I did not make any such changes |
I'm talking about L131, L377 and L386
I'll try and look into it |
I will just raise another PR, made some mistakes while rebasing last time |
Closes #4406