Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Crypto utils tests - ref #287 #300

Merged
merged 11 commits into from
Jun 30, 2023
Merged

Conversation

estefysc
Copy link
Contributor

No description provided.

@muke1908
Copy link
Owner

Hi @estefysc , take a look. Now it's passing. You can add the other UT now.

@estefysc
Copy link
Contributor Author

Hey, @muke1908. Checking now. Thanks for the help.

@estefysc estefysc marked this pull request as draft June 21, 2023 20:08
@estefysc estefysc marked this pull request as ready for review June 30, 2023 19:07
@estefysc
Copy link
Contributor Author

@muke1908 ready for review. Not too sure these are the best. Lest me know,

service/src/crypto.test.ts Outdated Show resolved Hide resolved
@sonarcloud
Copy link

sonarcloud bot commented Jun 30, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@muke1908
Copy link
Owner

@muke1908 ready for review. Not too sure these are the best. Lest me know,

Thanks for the contribution! These UTs are enough to test the basic crypto module.

@muke1908 muke1908 merged commit e2a99f9 into muke1908:master Jun 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants