Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove the PIN UI component #306

Merged
merged 2 commits into from
Jun 30, 2023
Merged

Remove the PIN UI component #306

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1f35883
Remove the PIN UI component
suitcasemedia Jun 30, 2023
5cc513d
remove pin display from import
suitcasemedia Jun 30, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 2 additions & 7 deletions client/src/components/LinkDisplay/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ const LinkDisplay = ({ content }) => {
<div className={styles.fullWidth}>
<div className={styles.divider} />
<span className={styles.pinDisplayMsg}>
Anyone with the PIN or the Link can join your chat
Anyone with the Link can join your chat
</span>
<div
className={`${styles.copyToClipboardContainer}
Expand Down Expand Up @@ -54,12 +54,7 @@ const LinkDisplay = ({ content }) => {
</button>
</div>
</div>
<div
className={`${styles.pinDisplay} ${darkMode ? styles.darkOpenLink : styles.lightOpenLink}`}
>
<span className={styles.pinValidMsg}>PIN (valid for 30 minutes)</span>
<PinDisplay content={content.pin} />
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can also remove PinDisplay from import

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No problem, done.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can also delete the PinDisplay component folder

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lets leave it for now

</div>

<div className={styles.divider} />
<div
className={`${styles.openLink}
Expand Down