Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

style: fix Copied button misalignment on mobile browsers #382

Merged
merged 4 commits into from
Sep 25, 2024
Merged

style: fix Copied button misalignment on mobile browsers #382

merged 4 commits into from
Sep 25, 2024

Conversation

hfdem
Copy link
Contributor

@hfdem hfdem commented Sep 24, 2024

photo_2024-09-24_11-48-07

@muke1908
Copy link
Owner

Thanks, but I thin a proper fix would be to remove text from the button and only icon. As I can see there is not enough space for text.

@hfdem
Copy link
Contributor Author

hfdem commented Sep 25, 2024

Thanks, but I thin a proper fix would be to remove text from the button and only icon. As I can see there is not enough space for text.

What about the QR Code next to it? Do you think it would also be better to replace it with an icon for mobile browsers?

@muke1908
Copy link
Owner

Thanks, but I thin a proper fix would be to remove text from the button and only icon. As I can see there is not enough space for text.

What about the QR Code next to it? Do you think it would also be better to replace it with an icon for mobile browsers?

Yes I think so.

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Sep 25, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@hfdem
Copy link
Contributor Author

hfdem commented Sep 25, 2024

@muke1908
屏幕截图 2024-09-25 231437

@muke1908 muke1908 merged commit 04fa8c7 into muke1908:master Sep 25, 2024
3 checks passed
hfdem added a commit to hfdem/chat-e2ee that referenced this pull request Sep 26, 2024
@hfdem
style: fix Copied button misalignment on mobile browsers (muke1908#382)
bb0f461 
* style: fix Copied button misalignment on mobile browsers

* perf: enhance QR code clarity using QRCodeSVG (muke1908#381)

* build: update dependencies (muke1908#383)
@hfdem hfdem deleted the patch-copystyle branch September 26, 2024 03:16
hfdem added a commit to hfdem/chat-e2ee that referenced this pull request Sep 26, 2024
@hfdem
style: fix Copied button misalignment on mobile browsers (muke1908#382)
6f758fc
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hfdem @muke1908