debugging html component #36
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for multi-website ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
✅ Deploy Preview for multi-site-preprod-core-texts ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
✅ Deploy Preview for multi-site-app-test ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
✅ Deploy Preview for multi-site-preprod ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
✅ Deploy Preview for datami-documentation ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
✅ Deploy Preview for datami ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Solution to #37
The problem was due to HtmlComponent live cycle : the component was indeed correctly loaded but the html injection was only working in case of a prop change, not in case the prop was correct before mounting.
So the correction added here consisted in adding a
beforeMountevent to the HtmlComponent script, in addition to thewatchevent. I also use this occasion to make the prop a bit more straight-forward by changing the expected type and its name : a prop namedrawHtml(expecting a String) instead ofsectionData(expecting an object).