Symmetric key encryption #53
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should resolve the symmetric keys issue.
A symmetric key will be generated right after a public key is received, so that the key can be encrypted using the public key. There's are checks to coordinate which party generates the key (parties with lower id).
There's also a new demo called sum-presentation which should help with logging and simulation of the scenario. Also added logging to the library itself. If you don't like the logging and think it's too cumbersome for the code, we can just roll back one commit. The logging is only in the final commit.
I've always tried to stick to the styles and conventions I see in the code as much as possible, and tried commenting as much as possible too. So finally please review the code and feed me back. I hope you like it =D