mptcpize: do not override existing LD_PRELOAD value #315
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If any. Before, previously set LD_PRELOAD were overridden. According to 'man ld.so', there can be more than one library to load before other objects as this env var accepts a list separated by spaces or colons: A list of additional, user-specified, ELF shared objects to be loaded before all others. This feature can be used to selectively override functions in other shared objects. The items of the list can be separated by spaces or colons, and there is no support for escaping either separator. So let's do that: if a previous LD_PRELOAD is detected, it will no longer be dropped, but used with the MPTCP Wrap library added at the end, e.g. LD_PRELOAD=dummy.so:libmptcpwrap.so.0.0.1 Signed-off-by: Matthieu Baerts (NGI0) <[email protected]>
Pull Request Test Coverage Report for Build 11959923174Details
💛 - Coveralls |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If any.
Before, previously set
LD_PRELOADwere overridden. According to 'man ld.so', there can be more than one library to load before other objects as this env var accepts a list separated by spaces or colons:So let's do that: if a previous
LD_PRELOADis detected, it will no longer be dropped, but used with the MPTCP Wrap library added at the end, e.g.cc: @pabeni