Add SC calls handling for ETH->MvX #267
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sasurobert
requested changes
Nov 28, 2023
clients/batch.go
Outdated
| return cloned | ||
| } | ||
|
|
||
| // SCBatch - |
clients/ethereum/client_test.go
Outdated
| @@ -5,6 +5,8 @@ import ( | |||
| "encoding/hex" | |||
| "errors" | |||
| "fmt" | |||
| "github.com/ethereum/go-ethereum" | |||
| "github.com/ethereum/go-ethereum/ethclient" | |||
clients/ethereum/interface.go
Outdated
| @@ -2,6 +2,7 @@ package ethereum | |||
|
|
|||
| import ( | |||
| "context" | |||
| "github.com/ethereum/go-ethereum" | |||
| @@ -2,6 +2,7 @@ package wrappers | |||
|
|
|||
| import ( | |||
| "context" | |||
| "github.com/ethereum/go-ethereum" | |||
clients/ethereum/client.go
Outdated
| "context" | ||
| "crypto/ecdsa" | ||
| "fmt" | ||
| "github.com/ethereum/go-ethereum" | ||
| "github.com/multiversx/mx-bridge-eth-go/clients/ethereum/contract" |
| return GettingPendingBatchFromEthereum | ||
| } | ||
|
|
||
| actionID, err := step.bridge.GetAndStoreActionIDForProposeSCTransferOnMultiversX(ctx) |
There was a problem hiding this comment.
why do we need new steps of 6 and 7 ? all the SC execution should be in parallel to this state-machine.
We would need a separate process where small bots are monitoring the SC which can forward call for executions.
sasurobert
previously approved these changes
Dec 12, 2023
iulianpascalau
previously approved these changes
Dec 13, 2023
…l fields in assertion to avoid false positives
… into sc-exec-impl
ccorcoveanu
dismissed stale reviews from iulianpascalau and sasurobert
via
cd241fe
iulianpascalau
approved these changes
Dec 14, 2023
sasurobert
approved these changes
Dec 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The flow should be as follows:
Since ETH contracts are non-upgradable we introduced a new proxy contract in front of the SafeContract.
This contract emits an event with some metadata we need for smart contract execution on MvX (tx data and gas limit + matching info like deposit and batch nonces) then forwards the deposit call to SafeContract.