Mx 15181 #292
Mx 15181 #292
Conversation
| isNativeOnMultiversX := executor.isNativeOnMultiversX(ctx, convertedToken) | ||
|
|
||
| if isNativeOnEthereum && isNativeOnMultiversX { | ||
| return fmt.Errorf("%w isNativeOnEthereum = %v, isNativeOnMultiversX = %v", ErrInvalidSetup, isNativeOnEthereum, isNativeOnMultiversX) |
| return executor.ethereumClient.CheckRequiredBalance(ctx, token, amount) | ||
| } | ||
| // transfer to MultiversX | ||
| return executor.multiversXClient.CheckRequiredBalance(ctx, convertedToken, amount) |
There was a problem hiding this comment.
from linter:
return executor.multiversXClient.CheckRequiredBalance(ctx, convertedToken, amount)
Check failure on line 626 in bridges/ethMultiversX/bridgeExecutor.goGitHub
Actions
/ Unit
executor.multiversXClient.CheckRequiredBalance undefined (type MultiversXClient has no field or method CheckRequiredBalance)
|
|
||
| burnBalances, err := executor.ethereumClient.BurnBalances(ctx, token) | ||
| if err != nil { | ||
| return big.NewInt(0), err |
There was a problem hiding this comment.
return nil, err ? Here and on L640
| } | ||
| burnBalances, err := executor.multiversXClient.BurnBalances(ctx, token) | ||
| if err != nil { | ||
| return big.NewInt(0), err |
There was a problem hiding this comment.
return nil, err ? Here and on L659
| func (executor *bridgeExecutor) isNativeOnEthereum(ctx context.Context, erc20Address common.Address) bool { | ||
| isNative, err := executor.ethereumClient.NativeTokens(ctx, erc20Address) | ||
| if err != nil { | ||
| return false |
There was a problem hiding this comment.
is this ok to assume here that the erc20 address is not native in case of an error? Also on isMintBurnOnMultiversX function. I think we should stop the further processing in case of an error as to not force the nodes to work in an undefined way
There was a problem hiding this comment.
no, refactored to return also error
| @@ -29,6 +29,7 @@ func ExtractListMvxToEth(batch *clients.TransferBatch) *ArgListsBatch { | |||
| arg.EthTokens = append(arg.EthTokens, token) | |||
|
|
|||
| amount := big.NewInt(0).Set(dt.Amount) | |||
| amount = big.NewInt(0).Neg(amount) | |||
| if isNativeOnEthereum && isNativeOnMultiversX { | ||
| return fmt.Errorf("%w isNativeOnEthereum = %v, isNativeOnMultiversX = %v", ErrInvalidSetup, isNativeOnEthereum, isNativeOnMultiversX) | ||
| } | ||
| return isMintBurnOnEthereum, nil | ||
| } | ||
|
|
||
| func (executor *bridgeExecutor) checkRequiredMintBurnBalance(ctx context.Context, ethToken common.Address, mvxToken []byte) error { | ||
| ethBalance, err := executor.ethereumClient.TokenMintedBalances(ctx, ethToken) | ||
| if err != nil { | ||
| return err | ||
| if !isMintBurnOnEthereum && !isMintBurnOnMultiversX { | ||
| return fmt.Errorf("%w isMintBurnOnEthereum = %v, isMintBurnOnMultiversX = %v", ErrInvalidSetup, isMintBurnOnEthereum, isMintBurnOnMultiversX) |
There was a problem hiding this comment.
can be reduced to one if if isMintBurnOnEthereum == isMintBurnOnMultiversX
There was a problem hiding this comment.
this one cannot be reduce to that because it is allowed to have both as mintBurn tokens
| return big.NewInt(0), err | ||
| } | ||
|
|
||
| if isNative { |
There was a problem hiding this comment.
should we also check if burnBalances >= mintBalances? similar for L64, L662, L664
dragos-rebegea
force-pushed
the
MX-15181
branch
from
86fb3c9
to
8f7a096
Compare
dragos-rebegea
changed the base branch from
feat/chain-simulator
to
feat-v3-arm64
No description provided.