Minor tests & production code fixes #314
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
iulianpascalau
commented
Jul 16, 2024
iulianpascalau
commented
- refactored & simplified the transaction sent status in tests
- minor fix in the set status step to avoid some false positives
- fixed prints in tests
- minor fix in the set status step to avoid some false positives - fixed prints in tests
sstanculeanu
previously approved these changes
Jul 17, 2024
dragos-rebegea
previously approved these changes
Jul 17, 2024
| @@ -22,12 +24,13 @@ func (step *resolveSetStatusStep) Execute(ctx context.Context) core.StepIdentifi | |||
| } | |||
|
|
|||
| batch, err := step.bridge.GetBatchFromMultiversX(ctx) | |||
| if err != nil { | |||
| step.bridge.PrintInfo(logger.LogError, "error while fetching batch", "error", err) | |||
| isEmptyBatch := batch == nil || (err != nil && errors.Is(err, clients.ErrNoPendingBatchAvailable)) | |||
There was a problem hiding this comment.
👍 this is a great improvement on the logging side
sstanculeanu
dismissed stale reviews from dragos-rebegea and themself
The base branch was changed.
sstanculeanu
approved these changes
Jul 17, 2024
dragos-rebegea
approved these changes
Jul 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.