-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add TestCaller contract on solidity #69
Conversation
contracts/TestCaller.sol
Outdated
|
||
function callNonPayable() public {} | ||
|
||
function callPayableWithParams(uint256 size, address addr, address tokenIdentifier) public payable { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I believe we can remove payable
modifier since we're not transferring Ether. Instead, on Ethereum, we're transferring erc20 token balances between accounts
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks, good observation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
good observation, indeed 👍
contracts/TestCaller.sol
Outdated
|
||
function upgrade() public {} | ||
|
||
function callPayable() public payable {} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
same here
No description provided.