Merge pull request #268 from multiversx/fix-linter-in-tests

Fixed linter issues in tests

Makefile

@@ -1,3 +1,15 @@
 test:
 	@echo "  >  Running unit tests"
 	go test -cover -race -coverprofile=coverage.txt -covermode=atomic -v ./...
+
+lint-install:
+ifeq (,$(wildcard test -f bin/golangci-lint))
+	@echo "Installing golint"
+	curl -sSfL https://raw.githubusercontent.com/golangci/golangci-lint/master/install.sh | sh -s
+endif
+
+run-lint:
+	@echo "Running golint"
+	bin/golangci-lint run --max-issues-per-linter 0 --max-same-issues 0 --timeout=2m
+
+lint: lint-install run-lint

data/outport/common_test.go

@@ -55,8 +55,7 @@ func TestGetBody(t *testing.T) {
 	require.Nil(t, receivedBody)
 	require.Equal(t, errNilBodyHandler, err)
 
-	var body data.BodyHandler
-	body = &block.Body{}
+	var body data.BodyHandler = &block.Body{}
 	receivedBody, err = GetBody(body)
 	require.Nil(t, err)
 	require.Equal(t, body, receivedBody)

data/transaction/transaction_test.go

@@ -351,8 +351,7 @@ func TestTransaction_CheckIntegrityShouldErr(t *testing.T) {
 func TestTransaction_ImplementsGuardedTransactionHandler(t *testing.T) {
 	t.Parallel()
 
-	var tx data.TransactionHandler
-	tx = &transaction.Transaction{}
+	var tx data.TransactionHandler = &transaction.Transaction{}
 
 	_, ok := tx.(data.GuardedTransactionHandler)
 	assert.True(t, ok)