esdts-improvements #270
Merged
esdts-improvements #270
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sasurobert
reviewed
Nov 1, 2023
core/constants.go
Outdated
| // NonFungibleV2 defines the token type for ESDT non fungible tokens | ||
| NonFungibleV2 | ||
| // Meta defines the token type for ESDT meta tokens | ||
| Meta |
There was a problem hiding this comment.
We have SFT as well. Plus bring here the DynamicNFT, DynamicSFT, DynamicMeta as well.
There was a problem hiding this comment.
change the order of semiFungible and Meta - maybe add MetaFungible - to have a complete name.
| return uint32(NonFungible), nil | ||
| case NonFungibleESDTv2: | ||
| return uint32(NonFungibleV2), nil | ||
| case MetaESDT: |
There was a problem hiding this comment.
add the more types, dynamics as well.
BeniaminDrasovean
changed the title
…n-constants # Conflicts: # data/outport/common_test.go
sasurobert
previously approved these changes
Nov 28, 2023
| @@ -177,3 +177,32 @@ func ConvertToEvenHexBigInt(value *big.Int) string { | |||
|
|
|||
| return str | |||
| } | |||
|
|
|||
| // ConvertESDTTypeToUint32 converts the esdt type to uint32 | |||
| func ConvertESDTTypeToUint32(esdtType string) (uint32, error) { | |||
core/constants.go
Outdated
| // NonFungibleV2 defines the token type for ESDT non fungible tokens | ||
| NonFungibleV2 | ||
| // Meta defines the token type for ESDT meta tokens | ||
| Meta |
iulianpascalau
approved these changes
Mar 6, 2024
sasurobert
approved these changes
Apr 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.