Common token prefix utility func #299
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mariusmihaic
changed the title
axenteoctavian
previously approved these changes
May 15, 2024
| minLengthESDTPrefix = 1 | ||
| ) | ||
|
|
||
| func IsValidPrefixedToken(token string) (string, bool) { |
sasurobert
reviewed
May 16, 2024
| // minLengthESDTPrefix represents the minimum number of characters a token's prefix can have | ||
| minLengthESDTPrefix = 1 | ||
| ) | ||
|
|
There was a problem hiding this comment.
should we have IsValidToken (as it was before) to understand prefixed tokens as well, not only non-prefixed ones ?
I think it should and it is possible.
It can be done with len of tokenSplit.
There was a problem hiding this comment.
In mx-chain-go we don't have any function which only does the validation for a simple token, we only have this func(which also does some validations):
ExtractTokenIDAndNonceFromTokenStorageKey.
However, that type of function is not being used in other places, so there was no need to create one and move it to core only to be used in the binary node.
sasurobert
approved these changes
May 17, 2024
axenteoctavian
approved these changes
May 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.