Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inner transactions in operations index #298

Open
wants to merge 10 commits into
base: rc/v1.7.next1
Choose a base branch
from

Conversation

miiu96
Copy link
Contributor

@miiu96 miiu96 commented Oct 7, 2024

@miiu96 miiu96 self-assigned this Oct 7, 2024
@@ -56,6 +56,7 @@ type ArgElasticProcessor struct {
DBClient DatabaseClientHandler
LogsAndEventsProc DBLogsAndEventsHandler
OperationsProc OperationsHandler
InnerTxsHandler InnerTxsHandler
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

missing nil check

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the check for nil is the check.go file and it's done on line 82.

sstanculeanu
sstanculeanu previously approved these changes Oct 8, 2024
@ssd04 ssd04 self-requested a review October 8, 2024 13:46
ssd04
ssd04 previously approved these changes Oct 8, 2024
@miiu96 miiu96 dismissed stale reviews from ssd04 and sstanculeanu via 327bd04 October 11, 2024 15:42
sstanculeanu
sstanculeanu previously approved these changes Oct 11, 2024
ssd04
ssd04 previously approved these changes Oct 11, 2024
@miiu96 miiu96 dismissed stale reviews from ssd04 and sstanculeanu via d1739ba October 11, 2024 17:28
sstanculeanu
sstanculeanu previously approved these changes Oct 11, 2024
ssd04
ssd04 previously approved these changes Oct 12, 2024
@miiu96 miiu96 dismissed stale reviews from ssd04 and sstanculeanu via 5709b0b October 17, 2024 10:32
sstanculeanu
sstanculeanu previously approved these changes Oct 17, 2024
"version": 0
}
]
}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

missing new line

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

added

sstanculeanu
sstanculeanu previously approved these changes Oct 17, 2024
ssd04
ssd04 previously approved these changes Oct 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants