Token type in altered accounts #6220
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sstanculeanu
previously approved these changes
Jun 19, 2024
sstanculeanu
previously approved these changes
Jun 19, 2024
sstanculeanu
previously approved these changes
Jun 20, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## rc/v1.7.next1 #6220 +/- ##
=================================================
- Coverage 78.79% 78.79% -0.01%
=================================================
Files 753 753
Lines 98848 98848
=================================================
- Hits 77887 77886 -1
Misses 15719 15719
- Partials 5242 5243 +1 ☔ View full report in Codecov by Sentry. |
ssd04
reviewed
Jun 20, 2024
| @@ -223,6 +223,7 @@ func (aap *alteredAccountsProvider) addTokensDataForMarkedAccount( | |||
| Nonce: nonce, | |||
| Properties: hex.EncodeToString(esdtToken.Properties), | |||
| MetaData: aap.convertMetaData(esdtToken.TokenMetaData), | |||
| Type: getTokenType(esdtToken.Type, nonce), | |||
There was a problem hiding this comment.
can we have some unit tests for sft, nft, metaesdt types?
ssd04
reviewed
Jul 2, 2024
| @@ -236,6 +237,16 @@ func (aap *alteredAccountsProvider) addTokensDataForMarkedAccount( | |||
| return nil | |||
| } | |||
|
|
|||
| func getTokenType(tokenType uint32, tokenNonce uint64) string { | |||
| isNotFungible := tokenNonce != 0 | |||
| tokenTypeNotSet := isNotFungible && core.ESDTType(tokenType) == core.Fungible | |||
There was a problem hiding this comment.
default old token here is core.NonFungible
ssd04
previously approved these changes
Jul 2, 2024
sstanculeanu
previously approved these changes
Jul 2, 2024
# Conflicts: # go.sum
ssd04
approved these changes
Jul 3, 2024
sstanculeanu
approved these changes
Jul 3, 2024
gabi-vuls
approved these changes
Jul 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reasoning behind the pull request
Proposed changes
Testing procedure
Pre-requisites
Based on the Contributing Guidelines the PR author and the reviewers must check the following requirements are met:
featbranch created?featbranch merging, do all satellite projects have a proper tag insidego.mod?