Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add new blockchain hooks #6319

Closed
wants to merge 23 commits into from
Closed

add new blockchain hooks #6319

wants to merge 23 commits into from
+792 −165

Conversation

laurci
Copy link

@laurci laurci commented Jul 16, 2024 •
edited
Loading

Reasoning behind the pull request

New blockchain hooks added:

  • RoundTime hook
  • EpochStartBlockTimeStamp hook
  • EpochStartBlockNonce hook
  • EpochStartBlockRound hook

Proposed changes

  • update mx-chain-vm-go mx-chain-vm-common-go and related mods
  • implementation for the new hooks

Testing procedure

Pre-requisites

Related PRs:

Based on the Contributing Guidelines the PR author and the reviewers must check the following requirements are met:

  • was the PR targeted to the correct branch?
  • if this is a larger feature that probably needs more than one PR, is there a feat branch created?
  • if this is a feat branch merging, do all satellite projects have a proper tag inside go.mod?

@laurci laurci marked this pull request as ready for review July 17, 2024 14:14
@miiu96
Copy link
Contributor

miiu96 commented Jul 19, 2024

can you please add in the PR description links with the other PRS.

@AdoAdoAdo AdoAdoAdo self-requested a review July 19, 2024 10:25
AdoAdoAdo
AdoAdoAdo requested changes Jul 19, 2024
View reviewed changes
process/smartContract/hooks/blockChainHook.go Outdated Show resolved Hide resolved
process/smartContract/hooks/blockChainHook.go Outdated Show resolved Hide resolved
process/smartContract/hooks/blockChainHook.go Outdated Show resolved Hide resolved
process/smartContract/hooks/blockChainHook.go Outdated Show resolved Hide resolved
process/smartContract/hooks/blockChainHook.go Outdated Show resolved Hide resolved
@laurci laurci changed the base branch from rc/v1.7.next1 to rc/v1.7.2 July 25, 2024 12:56
sasurobert
sasurobert previously approved these changes Jul 29, 2024
View reviewed changes
AdoAdoAdo
AdoAdoAdo requested changes Jul 29, 2024
View reviewed changes
epochStart/metachain/trigger.go Outdated Show resolved Hide resolved
factory/processing/blockProcessorCreator.go Show resolved Hide resolved
process/smartContract/hooks/blockChainHook.go Show resolved Hide resolved
process/smartContract/hooks/blockChainHook.go Outdated Show resolved Hide resolved
epochStart/shardchain/trigger.go Outdated Show resolved Hide resolved
AdoAdoAdo
AdoAdoAdo requested changes Jul 31, 2024
View reviewed changes
epochStart/shardchain/trigger.go Outdated Show resolved Hide resolved
epochStart/metachain/trigger.go Outdated Show resolved Hide resolved
process/smartContract/hooks/blockChainHook.go Outdated Show resolved Hide resolved
process/smartContract/scQueryService.go Show resolved Hide resolved
sasurobert
sasurobert reviewed Aug 1, 2024
View reviewed changes
process/smartContract/hooks/blockChainHook.go
@@ -838,6 +838,13 @@ func (bh *BlockChainHookImpl) updateEpochStartHeader(hdr data.HeaderHandler) err
return nil
}

func (bh *BlockChainHookImpl) SetEpochStartHeader(header data.HeaderHandler) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

missing comment

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

added comment

AdoAdoAdo
AdoAdoAdo previously approved these changes Aug 1, 2024
View reviewed changes
AdoAdoAdo
AdoAdoAdo reviewed Aug 1, 2024
View reviewed changes
Copy link
Contributor

@AdoAdoAdo AdoAdoAdo left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should check the start in epoch scenario and VM queries with blocks from latest two epochs

@raduchis raduchis deleted the branch del-rc/v1.7.2 October 2, 2024 09:07
@raduchis raduchis closed this Oct 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sasurobert sasurobert sasurobert left review comments

@AdoAdoAdo AdoAdoAdo AdoAdoAdo left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@laurci @miiu96 @sasurobert @AdoAdoAdo @raduchis