Preps for esdt-safe integration tests #6542
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
axenteoctavian
changed the title
Base automatically changed from
merge-rc-1-7-next-into-esdt-prefix-16-oct
to
feat/esdt-prefix
October 17, 2024 11:24
mariusmihaic
requested changes
Oct 18, 2024
Comment on lines
-89
to
-91
| "@000000000000000005004c13819a7f26de997e7c6720a6efe2d4b85c0609c9ad" + // price_aggregator_address | ||
| "@" + hex.EncodeToString([]byte("USDC-350c4e")) + // usdc_token_id | ||
| "@" + hex.EncodeToString([]byte("WEGLD-a28c59")) // wegld_token_id |
There was a problem hiding this comment.
Is it ok we don't have any fee market address set and tested anymore?
| @@ -109,8 +114,36 @@ func deployBridgeSetup( | |||
| } | |||
| } | |||
|
|
|||
| // Deposit will deposit tokens in the bridge sc safe contract | |||
| func Deposit( | |||
| func enshrineEsdtSafeContract( | |||
There was a problem hiding this comment.
This is literally the same function as simpleEnshrineEsdtSafeContract , only called with a different argument for DeployContract
There was a problem hiding this comment.
You could've simply just passed from deployBridgeSetup contract address.
| @@ -289,7 +288,7 @@ func IssueFungible( | |||
| txResult := SendTransaction(t, cs, sender, nonce, vm.ESDTSCAddress, issueCost, issueArgs, uint64(60000000)) | |||
| RequireSuccessfulTransaction(t, txResult) | |||
|
|
|||
| return getEsdtIdentifier(t, nodeHandler, tokenTicker, core.FungibleESDT) | |||
| return getEsdtIdentifier(t, cs.GetNodeHandler(core.MetachainShardId), tokenTicker, core.FungibleESDT) | |||
There was a problem hiding this comment.
This will break sovereign integration tests if the function is used. Should be reverted.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reasoning behind the pull request
Proposed changes
Testing procedure
Pre-requisites
Based on the Contributing Guidelines the PR author and the reviewers must check the following requirements are met:
featbranch created?featbranch merging, do all satellite projects have a proper tag insidego.mod?