new core-go #465
Open
new core-go #465
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AdoAdoAdo
previously approved these changes
Oct 10, 2024
andreibancioiu
previously approved these changes
Oct 10, 2024
sstanculeanu
dismissed stale reviews from andreibancioiu and AdoAdoAdo
via
5d5e537
README.md
Outdated
| @@ -35,6 +35,7 @@ For more details, go [here](https://docs.multiversx.com/sdk-and-tools/proxy/). | |||
| - `/v1.0/transaction/cost` (POST) --> receives a single transaction in JSON format and returns it's cost | |||
| - `/v1.0/transaction/:txHash` (GET) --> returns the transaction which corresponds to the hash | |||
| - `/v1.0/transaction/:txHash?withResults=true` (GET) --> returns the transaction and results which correspond to the hash | |||
| - `/v1.0/transaction/:txHash?withResults=true&withRelayedTxHash=:relayedTxHash` (GET) --> returns the inner transaction which corresponds to the hash and was part of the relayedTxHash | |||
There was a problem hiding this comment.
Without the suffix with (since, currently, we use with to dictate whether something has to be included in the response).
common/options.go
Outdated
| @@ -49,6 +49,8 @@ const ( | |||
| UrlParameterWithAlteredAccounts = "withAlteredAccounts" | |||
| // UrlParameterWithKeys represents the name of an URL parameter | |||
| UrlParameterWithKeys = "withKeys" | |||
| // UrlParameterWithRelayedTxHash represents the name of an URL parameter | |||
| UrlParameterWithRelayedTxHash = "withRelayedTxHash" | |||
There was a problem hiding this comment.
Without the with prefix. This new parameter is closer (in meaning) to hintEpoch than to withTxs.
process/transactionProcessor.go
Outdated
Comment on lines
434
to
452
| func isResultOfInnerTx(allScrs []*transaction.ApiSmartContractResult, currentScr *transaction.ApiSmartContractResult, innerTxHash string) bool { | ||
| if currentScr.PrevTxHash == innerTxHash { | ||
| return true | ||
| } | ||
|
|
||
| parentScr := getParentSCR(allScrs, currentScr.PrevTxHash) | ||
| if check.IfNilReflect(parentScr) { | ||
| return false | ||
| } | ||
|
|
||
| return isResultOfInnerTx(allScrs, parentScr, innerTxHash) | ||
| } | ||
|
|
||
| func getParentSCR(allScrs []*transaction.ApiSmartContractResult, hash string) *transaction.ApiSmartContractResult { | ||
| for _, scr := range allScrs { | ||
| if scr.Hash == hash { | ||
| return scr | ||
| } | ||
| } |
There was a problem hiding this comment.
currentScr is used for its PrevTxHash only. Thus, an optimization would be to hold a map of [previous hash] to [hash]. This way, the repeated loops can be omitted. However, in practice, the optimization would only be marginal. Thus, all right as it is now, as well 👍
process/transactionProcessor.go
Outdated
| return isResultOfInnerTx(allScrs, parentScr, innerTxHash) | ||
| } | ||
|
|
||
| func getParentSCR(allScrs []*transaction.ApiSmartContractResult, hash string) *transaction.ApiSmartContractResult { |
There was a problem hiding this comment.
Maybe can be named findSCRByHash().
andreibancioiu
approved these changes
Oct 14, 2024
AdoAdoAdo
approved these changes
Oct 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.