Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed the URL parameter for hint epoch #466

Open
wants to merge 2 commits into
base: rc/v1.7.next1
Choose a base branch
from

Conversation

iulianpascalau
Copy link
Contributor

  • fixed the URL parameter for hint epoch

andreibancioiu
andreibancioiu previously approved these changes Oct 16, 2024
HasValue: true,
},
}
options, err := parseAccountQueryOptions(createDummyGinContextWithQuery("hintEpoch=3737"), "")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙈

@@ -85,7 +85,7 @@ func parseAccountQueryOptions(c *gin.Context, address string) (common.AccountQue
return common.AccountQueryOptions{}, err
}

hintEpoch, err := parseUint32UrlParam(c, common.UrlParameterOnStartOfEpoch)
hintEpoch, err := parseUint32UrlParam(c, common.UrlParameterHintEpoch)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Indeed, UrlParameterOnStartOfEpoch was handled above. Good catch!

sstanculeanu
sstanculeanu previously approved these changes Oct 16, 2024
@andreibancioiu andreibancioiu changed the base branch from master to rc/v1.7.next1 October 16, 2024 07:11
@andreibancioiu andreibancioiu dismissed stale reviews from sstanculeanu and themself October 16, 2024 07:11

The base branch was changed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants