game sc tests #31
Merged
game sc tests #31
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Contract comparison - from 428c8db to d1d9f14
|
alyn509
previously approved these changes
Oct 6, 2023
contracts/mvx-game-sc/src/owner.rs
Outdated
| @@ -35,7 +35,7 @@ pub trait OwnerModule: crate::private::PrivateModule + crate::storage::StorageMo | |||
|
|
|||
| for (winner, percentage) in val.into_iter() { | |||
| let reward_per_winner = | |||
| &BigUint::from(percentage) * &total_wager / &BigUint::from(100u64); | |||
| &BigUint::from(percentage) * &total_wager / &BigUint::from(10000u64); | |||
There was a problem hiding this comment.
Rust accepts _ character in integers, so best practice are:
10_000u64- declare a constant with an intuitive name
| .put_account( | ||
| USER3_ADDR, | ||
| Account::new() | ||
| .nonce(4) |
There was a problem hiding this comment.
Starting nonces should be 1 for each account so you can more easily compute nonces with executed transactions.
| caller: &str, | ||
| game_sc: &mut ContractInfo<mvx_game_sc::Proxy<StaticApi>>, | ||
| ) -> &mut Self { | ||
| self.world.sc_call( | ||
| ScCallStep::new() | ||
| .from(caller) | ||
| .to(GAME_SC_ADDR) | ||
| .esdt_transfer(TOKEN_ID, 0u64, BigUint::from(STARTING_FEE)) | ||
| .esdt_transfer(TOKEN_ID, 0u64, BigUint::<StaticApi>::from(STARTING_FEE)) |
There was a problem hiding this comment.
I thinkg BigUint::from(STARTING_FEE) should be enough. Check for the imported BigUint (because there are 2).
You should use multiversx_sc_scenario::num_bigint::BigUint.
alyn509
approved these changes
Oct 9, 2023
CostinCarabas
approved these changes
Oct 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.