added docs and small owner fix #32
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Contract comparison - from 38ce1b3 to 03c6823
|
psorinionut
reviewed
Oct 9, 2023
contracts/mvx-game-sc/README.md
Outdated
|
|
||
| The game is considered `invalid` until the `minimum number of players` have joined the game and if the `waiting time` has passed, no more players can join. | ||
|
|
||
| The SC does not have any logic for calculating the winner, so it expects input from the owner with the winnes' addresses and the percentage (*100) of the total reward (sum of wagers) won by each. |
There was a problem hiding this comment.
it expects input from the owner with the winners' addresses
psorinionut
reviewed
Oct 9, 2023
contracts/mvx-game-sc/README.md
Outdated
| **The game**: | ||
| - If the game is `invalid`, the `wager` amount will be returned to the players that have joined the game and the `game starting fee` will be returned to the creator | ||
| - If the game is `valid`, but no winners are sent by the owner, such in the case of a tie/draw, the contract will send back the `wager` amount paid by every player who joined | ||
| - If the game is `valid` and winners are sent by the owner, the SC will send the reward to the winners as explained by the owner |
There was a problem hiding this comment.
Maybe rephrase a little, as the owner does not explain anything.
Something like
If the game is valid and the winners were provided, the SC will send the rewards to them, based on the input of the owner.
psorinionut
reviewed
Oct 9, 2023
contracts/mvx-game-sc/README.md
Outdated
|
|
||
| ## Endpoints | ||
| ### createGame | ||
| ``` |
There was a problem hiding this comment.
It is better formated if you write the programming language, so add rust after the first ```, like so:
...
psorinionut
reviewed
Oct 10, 2023
contracts/mvx-game-sc/README.md
Outdated
| - If the game is `valid`, but no winners are sent by the owner, such in the case of a tie/draw, the contract will send back the `wager` amount paid by every player who joined | ||
| - If the game is `valid` and winners are sent by the owner, the SC will send the reward to the winners as explained by the owner | ||
| - If the game is `valid`, but no winners are provided, such in the case of a tie/draw, the contract will send back the `wager` amount paid by every player who joined | ||
| - If the game is `valid` and winners are provided, the SC will send the reward to the them, based on the input of the owner. |
There was a problem hiding this comment.
send the rewards to them
psorinionut
approved these changes
Oct 10, 2023
dorin-iancu
approved these changes
Oct 10, 2023
alyn509
approved these changes
Oct 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.