Paymaster audit fixes #33
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Contract comparison - from 3ec6ea1 to 55d4dae
|
sasurobert
reviewed
Oct 10, 2023
sasurobert
previously approved these changes
Oct 10, 2023
sasurobert
reviewed
Oct 11, 2023
…master_audit_fixes
psorinionut
reviewed
Nov 26, 2023
| @@ -5,7 +5,6 @@ multiversx_sc::imports!(); | |||
| pub mod forward_call; | |||
| const FEE_PAYMENT: usize = 0; | |||
There was a problem hiding this comment.
Maybe rename to FEE_PAYMENT_INDEX for more clarity.
| @@ -5,7 +5,6 @@ multiversx_sc::imports!(); | |||
| pub mod forward_call; | |||
| const FEE_PAYMENT: usize = 0; | |||
|
|
|||
| /// An empty contract. To be used as a template when starting a new contract from scratch. | |||
| #[multiversx_sc::contract] | |||
| pub trait PaymasterContract: forward_call::ForwardCall { | |||
| #[init] | |||
There was a problem hiding this comment.
I can't add a comment on the unmodified code, but to have a safer approach regarding the fees in the forwardExecution endpoint, I would change the fee_payment nonce for the relayer_addr to fee_payment.token_nonce, instead of hardcoding the value 0, as the code would crash (without having a custom error) if the user would send an SFT. Now, if you want to allow only fungible tokens, do the check that the payment's nonce is 0. But still, I would keep the token_nonce approach.
psorinionut
approved these changes
Nov 28, 2023
sasurobert
approved these changes
Nov 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.