Skip to content

New multisig rewrite tests #556

New multisig rewrite tests

New multisig rewrite tests #556

GitHub Actions / clippy failed Aug 8, 2024 in 1s

reviewdog [clippy] report

reported by reviewdog 🐶

Findings (1)

contracts/multisig-improved/tests/ms_improved_setup/mod.rs|343 col 21| warning: this let-binding has unit value
--> contracts/multisig-improved/tests/ms_improved_setup/mod.rs:343:21
|
343 | let _ = sc.sign(action_id, signatures);
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: omit the let binding: sc.sign(action_id, signatures);
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value
= note: #[warn(clippy::let_unit_value)] on by default

Filtered Findings (4)

contracts/nft-minter/src/nft_module.rs|127 col 41| warning: the borrowed expression implements the required traits
--> contracts/nft-minter/src/nft_module.rs:127:41
|
127 | self.nft_token_id().set(&token_id.unwrap_esdt());
| ^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: token_id.unwrap_esdt()
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args
= note: #[warn(clippy::needless_borrows_for_generic_args)] on by default
contracts/multisig-improved/src/common_types/user_role.rs|76 col 5| warning: doc list item missing indentation
--> contracts/multisig-improved/src/common_types/user_role.rs:76:5
|
76 | /// Will keep the board size and proposer count in sync.
| ^
|
= help: if this is supposed to be its own paragraph, add a blank line
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_lazy_continuation
= note: #[warn(clippy::doc_lazy_continuation)] on by default
help: indent this line
|
76 | /// Will keep the board size and proposer count in sync.
| ++
contracts/multisig-improved/src/common_types/user_role.rs|76 col 5| warning: doc list item missing indentation
--> contracts/multisig-improved/src/common_types/user_role.rs:76:5
|
76 | /// Will keep the board size and proposer count in sync.
| ^
|
= help: if this is supposed to be its own paragraph, add a blank line
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_lazy_continuation
= note: #[warn(clippy::doc_lazy_continuation)] on by default
help: indent this line
|
76 | /// Will keep the board size and proposer count in sync.
| ++
contracts/nft-minter/src/nft_module.rs|127 col 41| warning: the borrowed expression implements the required traits
--> contracts/nft-minter/src/nft_module.rs:127:41
|
127 | self.nft_token_id().set(&token_id.unwrap_esdt());
| ^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: token_id.unwrap_esdt()
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args
= note: #[warn(clippy::needless_borrows_for_generic_args)] on by default

Annotations

Check warning on line 343 in contracts/multisig-improved/tests/ms_improved_setup/mod.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

[clippy] contracts/multisig-improved/tests/ms_improved_setup/mod.rs#L343

warning: this let-binding has unit value
   --> contracts/multisig-improved/tests/ms_improved_setup/mod.rs:343:21
    |
343 |                     let _ = sc.sign(action_id, signatures);
    |                     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: omit the `let` binding: `sc.sign(action_id, signatures);`
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value
    = note: `#[warn(clippy::let_unit_value)]` on by default
Raw output
contracts/multisig-improved/tests/ms_improved_setup/mod.rs:343:21:w:warning: this let-binding has unit value
   --> contracts/multisig-improved/tests/ms_improved_setup/mod.rs:343:21
    |
343 |                     let _ = sc.sign(action_id, signatures);
    |                     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: omit the `let` binding: `sc.sign(action_id, signatures);`
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value
    = note: `#[warn(clippy::let_unit_value)]` on by default


__END__