onBehalf audit fixes + unit tests #996
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Coverage SummaryTotals
FilesExpand
|
|
Contract comparison - from 58a7e74 to 045e4ac
|
psorinionut
changed the title
dorin-iancu
reviewed
Jan 14, 2025
| @@ -21,7 +28,7 @@ pub trait OriginalOwnerHelperModule { | |||
| } else { | |||
| require!( | |||
| original_owner == payment_original_owner, | |||
| "All position must have the same original owner" | |||
| "Original owner is not the same for all payments" | |||
There was a problem hiding this comment.
Can't comment on the whole code, but instead of using ManagedAddress::zero() as the default value, you could do this to make it more clear:
let mut opt_original_owner = None;
//// other code
for ...
{
/////
match opt_original_owner {
Some(original_owner) => require!(...),
None => opt_original_owner = Some(payment_original_owner),
}
}
Comment on lines
114
to
117
| require!( | ||
| lp_original_owner != ManagedAddress::zero(), | ||
| "LP Token original owner incorrect" | ||
| ); |
There was a problem hiding this comment.
Use the is_zero() method of ManagedAddress instead.
Comment on lines
114
to
117
| require!( | ||
| lp_original_owner != ManagedAddress::zero(), | ||
| "LP Token original owner incorrect" | ||
| ); |
There was a problem hiding this comment.
Suggested change
| require!( | |
| lp_original_owner != ManagedAddress::zero(), | |
| "LP Token original owner incorrect" | |
| ); | |
| require!( | |
| !lp_original_owner.is_zero(), | |
| "LP Token original owner incorrect" | |
| ); |
dorin-iancu
previously approved these changes
Jan 14, 2025
andreiblt1304
previously approved these changes
Jan 16, 2025
CostinCarabas
previously approved these changes
Jan 16, 2025
psorinionut
dismissed stale reviews from CostinCarabas, andreiblt1304, and dorin-iancu
via
045e4ac
andreiblt1304
approved these changes
Jan 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.