Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MEX-333] pair fees collector #1112

Merged

Conversation

claudiulataretu
Copy link
Collaborator

Reasoning

  • add missing pair information

Proposed Changes

  • add fees collector address from pair
  • add fees collector cut percentage

How to test

query Pairs {
	pairs(offset: 0, limit: 100) {
		address
		feesCollector {address}
		feesCollectorCutPercentage
	}
}
  • query should return values for pairs with fees collector enabled and null otherwise

…warmer

- removed unused setter methods from pair setter service

Signed-off-by: Claudiu Lataretu <[email protected]>
@claudiulataretu claudiulataretu changed the title Mex 333 pair fees collector address [MEX-333] pair fees collector Jul 21, 2023
@codecov
Copy link

codecov bot commented Jul 21, 2023

Codecov Report

Patch coverage: 26.31% and project coverage change: -0.08 ⚠️

Comparison is base (87bbf9b) 56.42% compared to head (377c989) 56.35%.

Additional details and impacted files
@@                   Coverage Diff                    @@
##           feat/admin-endpoints    #1112      +/-   ##
========================================================
- Coverage                 56.42%   56.35%   -0.08%     
========================================================
  Files                       233      233              
  Lines                      7691     7710      +19     
  Branches                    515      517       +2     
========================================================
+ Hits                       4340     4345       +5     
- Misses                     2911     2923      +12     
- Partials                    440      442       +2     
Flag Coverage Δ
unittests 56.35% <26.31%> (-0.08%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/modules/pair/services/pair.abi.service.ts 16.66% <12.50%> (-0.31%) ⬇️
src/modules/pair/models/pair.model.ts 94.73% <100.00%> (+0.29%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@claudiulataretu claudiulataretu marked this pull request as ready for review July 24, 2023 15:31
@claudiulataretu claudiulataretu merged commit f805fe3 into feat/admin-endpoints Jul 25, 2023
2 of 4 checks passed
@claudiulataretu claudiulataretu deleted the MEX-333-pair-fees-collector-address branch July 25, 2023 07:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants