-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[MEX-331] fees collector admin endpoints #1117
Merged
claudiulataretu
merged 3 commits into
feat/admin-endpoints
from
MEX-331-fees-collector-admin-endpoints
Jul 25, 2023
Merged
[MEX-331] fees collector admin endpoints #1117
claudiulataretu
merged 3 commits into
feat/admin-endpoints
from
MEX-331-fees-collector-admin-endpoints
Jul 25, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- knownContracts endpoints - knownTokens endpoints Signed-off-by: Claudiu Lataretu <[email protected]>
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## feat/admin-endpoints #1117 +/- ##
========================================================
+ Coverage 56.32% 56.37% +0.05%
========================================================
Files 233 233
Lines 7718 7728 +10
Branches 517 519 +2
========================================================
+ Hits 4347 4357 +10
Misses 2929 2929
Partials 442 442
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
cfaur09
previously approved these changes
Jul 25, 2023
danielailie
reviewed
Jul 25, 2023
src/modules/fees-collector/services/fees-collector.transaction.service.ts
Show resolved
Hide resolved
src/modules/fees-collector/services/fees-collector.transaction.service.ts
Outdated
Show resolved
Hide resolved
- update methods names - added description for queries Signed-off-by: Claudiu Lataretu <[email protected]>
danielailie
previously approved these changes
Jul 25, 2023
Signed-off-by: Claudiu Lataretu <[email protected]>
danielailie
approved these changes
Jul 25, 2023
cfaur09
approved these changes
Jul 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reasoning
Proposed Changes
How to test