Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MEX-331] fees collector admin endpoints #1117

Merged

Conversation

claudiulataretu
Copy link
Collaborator

Reasoning

  • fees collector resolver missed some of admin endpoints

Proposed Changes

  • add known contracts update endpoints
  • add known tokens update endpoints

How to test

- knownContracts endpoints
- knownTokens endpoints

Signed-off-by: Claudiu Lataretu <[email protected]>
@codecov
Copy link

codecov bot commented Jul 24, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: +0.05% 🎉

Comparison is base (233bbcc) 56.32% compared to head (30e8787) 56.37%.

Additional details and impacted files
@@                   Coverage Diff                    @@
##           feat/admin-endpoints    #1117      +/-   ##
========================================================
+ Coverage                 56.32%   56.37%   +0.05%     
========================================================
  Files                       233      233              
  Lines                      7718     7728      +10     
  Branches                    517      519       +2     
========================================================
+ Hits                       4347     4357      +10     
  Misses                     2929     2929              
  Partials                    442      442              
Flag Coverage Δ
unittests 56.37% <100.00%> (+0.05%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
...tor/services/fees-collector.transaction.service.ts 90.90% <100.00%> (+3.95%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

cfaur09
cfaur09 previously approved these changes Jul 25, 2023
- update methods names
- added description for queries

Signed-off-by: Claudiu Lataretu <[email protected]>
danielailie
danielailie previously approved these changes Jul 25, 2023
Signed-off-by: Claudiu Lataretu <[email protected]>
@claudiulataretu claudiulataretu merged commit d7451de into feat/admin-endpoints Jul 25, 2023
3 checks passed
@claudiulataretu claudiulataretu deleted the MEX-331-fees-collector-admin-endpoints branch July 25, 2023 08:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants