Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MEX-336] setupFeesCollector in pair module #1121

Merged

Conversation

claudiulataretu
Copy link
Collaborator

Reasoning

  • missing admin query in pair module

Proposed Changes

  • add setupFeesCollector tx generator in pair module

How to test

query SetupFeesCollector {
  setupFeesCollector(pairAddress: "erd1qqqqqqqqqqqqqpgquu5rsa4ee6l4azz6vdu4hjp8z4p6tt8m0n4suht3dy") {
    data
  }
}
  • query should return generated tx

gabrielmatei
gabrielmatei previously approved these changes Jul 25, 2023
@codecov
Copy link

codecov bot commented Jul 25, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: +0.01% 🎉

Comparison is base (d7451de) 56.37% compared to head (575edfc) 56.39%.

Additional details and impacted files
@@                   Coverage Diff                    @@
##           feat/admin-endpoints    #1121      +/-   ##
========================================================
+ Coverage                 56.37%   56.39%   +0.01%     
========================================================
  Files                       233      233              
  Lines                      7728     7730       +2     
  Branches                    519      519              
========================================================
+ Hits                       4357     4359       +2     
  Misses                     2929     2929              
  Partials                    442      442              
Flag Coverage Δ
unittests 56.39% <100.00%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
...modules/pair/services/pair.transactions.service.ts 80.89% <100.00%> (+0.24%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

danielailie
danielailie previously approved these changes Jul 25, 2023
@claudiulataretu claudiulataretu merged commit 3eea0c8 into feat/admin-endpoints Jul 25, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants