[SERVICES-1740] optimal staking compound

[claudiulataretu]

Reasoning

• staking contracts positions can be compounded directly without rewards harvesting; because investment and rewards are the same type, we can compound the rewards and calculate the optimal frequency for compounding

Proposed Changes

• add method to compute optimal compound frequency for any staking position expressed in hours and minutes interval

How to test

query OptimalCompound {
	getOptimalCompoundFrequency(
		stakeAddress: "erd1qqqqqqqqqqqqqpgq8w0s682m88xae2ne3qkq7w2h26u5a5c00n4stt02d7",
		amount: "900000000000000000000",
		timeInterval: 365
	) {
		interval
		hours
		minutes
	}
}

• query should return an OptimalCompound object

{
  "optimalProfit": 114.31687566993836,
  "interval": 34,
  "days": 10,
  "hours": 17,
  "minutes": 38
}

[jacobleygonie]

Overall the logic is correct. Added a few comments for possible improvements.

[codecov]

Codecov Report

Patch coverage: 96.66% and project coverage change: +0.12% 🎉

Comparison is base (13368f2) 56.38% compared to head (64c7258) 56.51%.
Report is 3 commits behind head on development.

Additional details and impacted files

@@               Coverage Diff               @@
##           development    #1123      +/-   ##
===============================================
+ Coverage        56.38%   56.51%   +0.12%     
===============================================
  Files              233      233              
  Lines             7748     7778      +30     
  Branches           518      519       +1     
===============================================
+ Hits              4369     4396      +27     
- Misses            2936     2938       +2     
- Partials           443      444       +1     

Flag	Coverage Δ
unittests	56.51% <96.66%> (+0.12%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed	Coverage Δ
src/modules/pair/mocks/pair.constants.ts	62.06% <ø> (ø)
...odules/staking/services/staking.compute.service.ts	82.50% <95.45%> (+4.91%)	⬆️
src/modules/staking/models/staking.model.ts	100.00% <100.00%> (ø)
.../modules/tokens/mocks/token.getter.service.mock.ts	100.00% <100.00%> (ø)

... and 2 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.