Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MEX-353] fix outdated claim progress #1147

Merged
merged 2 commits into from
Aug 18, 2023
Merged

[MEX-353] fix outdated claim progress #1147

merged 2 commits into from
Aug 18, 2023

Conversation

claudiulataretu
Copy link
Collaborator

Reasoning

  • Outdated claim progress flag is not taken into account when an outdated contract is verified

Proposed Changes

  • check also the outdated claim progress when compute outdated contracts

How to test

query UserOutdatedContracts {
	userOutdatedContracts {
		address
		type
		claimProgressOutdated
	}
}
  • query should return a contract event when the energy is in sync but boosted rewards was not harvested

@codecov
Copy link

codecov bot commented Aug 18, 2023

Codecov Report

Patch coverage: 50.00% and project coverage change: +0.03% 🎉

Comparison is base (741eeb8) 56.43% compared to head (15df34e) 56.47%.
Report is 4 commits behind head on development.

Additional details and impacted files
@@               Coverage Diff               @@
##           development    #1147      +/-   ##
===============================================
+ Coverage        56.43%   56.47%   +0.03%     
===============================================
  Files              235      235              
  Lines             7878     7880       +2     
  Branches           529      529              
===============================================
+ Hits              4446     4450       +4     
+ Misses            2980     2978       -2     
  Partials           452      452              
Flag Coverage Δ
unittests 56.47% <50.00%> (+0.03%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
...services/userEnergy/user.energy.compute.service.ts 47.50% <50.00%> (+2.62%) ⬆️

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dragos-rebegea dragos-rebegea merged commit 61a8281 into development Aug 18, 2023
2 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants