Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SERVICES-1760] eslint fixes #1151

Open
wants to merge 13 commits into
base: development
Choose a base branch
from

Conversation

claudiulataretu
Copy link
Collaborator

Reasoning

  • eslint errors and warnings were not resolved

Proposed Changes

  • solve eslint errors and warnings
  • update eslint file
  • add linter workflow

How to test

  • N/A

@codecov
Copy link

codecov bot commented Aug 21, 2023

Codecov Report

Patch coverage: 22.72% and project coverage change: -0.02% ⚠️

Comparison is base (32e81ac) 56.52% compared to head (fedc6c6) 56.51%.

Additional details and impacted files
@@               Coverage Diff               @@
##           development    #1151      +/-   ##
===============================================
- Coverage        56.52%   56.51%   -0.02%     
===============================================
  Files              235      235              
  Lines             7882     7887       +5     
  Branches           530      532       +2     
===============================================
+ Hits              4455     4457       +2     
- Misses            2974     2975       +1     
- Partials           453      455       +2     
Flag Coverage Δ
unittests 56.51% <22.72%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
src/common.app.module.ts 72.72% <0.00%> (ø)
...odules/auto-router/services/auto-router.service.ts 66.66% <0.00%> (-2.63%) ⬇️
...rc/modules/energy/mocks/energy.abi.service.mock.ts 38.46% <ø> (ø)
.../farm/base-module/services/farm.compute.service.ts 79.36% <ø> (ø)
...odules/farm/custom/services/farm.custom.service.ts 88.23% <ø> (ø)
src/modules/farm/mocks/farm.service.mock.ts 50.00% <ø> (ø)
...c/modules/farm/mocks/farm.v1.2.abi.service.mock.ts 57.14% <ø> (ø)
...c/modules/farm/mocks/farm.v1.3.abi.service.mock.ts 66.66% <ø> (ø)
src/modules/farm/mocks/farm.v2.abi.service.mock.ts 30.76% <ø> (ø)
...odules/farm/v1.3/services/farm.v1.3.abi.service.ts 40.62% <ø> (+4.51%) ⬆️
... and 29 more

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

dragos-rebegea
dragos-rebegea previously approved these changes Aug 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants