Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MEX-353] fix outdated contracts for users with no energy #1154

Merged
merged 2 commits into from
Aug 23, 2023

Conversation

claudiulataretu
Copy link
Collaborator

Reasoning

  • users with no claim progress in farms or fees collector should not get outdated energy pop-up for these contracts

Proposed Changes

  • add check for claim progress week

How to test

query UserOutdatedContracts {
	userOutdatedContracts {
		address
		type
		claimProgressOutdated
	}
}
  • query should return empty array for accounts with no energy

- check for claim progress week for computed energy outdated contracts in
farms

Signed-off-by: Claudiu Lataretu <[email protected]>
@codecov
Copy link

codecov bot commented Aug 22, 2023

Codecov Report

Patch coverage: 25.00% and project coverage change: -0.02% ⚠️

Comparison is base (32e81ac) 56.52% compared to head (e5f3d33) 56.50%.
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1154      +/-   ##
==========================================
- Coverage   56.52%   56.50%   -0.02%     
==========================================
  Files         235      235              
  Lines        7882     7886       +4     
  Branches      530      532       +2     
==========================================
+ Hits         4455     4456       +1     
- Misses       2974     2975       +1     
- Partials      453      455       +2     
Flag Coverage Δ
unittests 56.50% <25.00%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
...services/userEnergy/user.energy.compute.service.ts 46.42% <25.00%> (-1.08%) ⬇️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@claudiulataretu claudiulataretu merged commit ecada02 into main Aug 23, 2023
1 of 3 checks passed
@claudiulataretu claudiulataretu deleted the MEX-353 branch August 23, 2023 07:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants