Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MEX-362: remove totalVotingPower field #1162

Closed
wants to merge 1 commit into from
Closed

Conversation

dragos-rebegea
Copy link
Contributor

Reasoning

  • totalVotingPower has wrongly computed and cannot be computed before having all the votes, thus the field will be removed

@codecov
Copy link

codecov bot commented Aug 30, 2023

Codecov Report

Patch coverage: 16.66% and project coverage change: -0.02% ⚠️

Comparison is base (52d1f89) 56.52% compared to head (93ae308) 56.51%.
Report is 40 commits behind head on development.

Additional details and impacted files
@@               Coverage Diff               @@
##           development    #1162      +/-   ##
===============================================
- Coverage        56.52%   56.51%   -0.02%     
===============================================
  Files              235      235              
  Lines             7882     7887       +5     
  Branches           530      532       +2     
===============================================
+ Hits              4455     4457       +2     
- Misses            2974     2975       +1     
- Partials           453      455       +2     
Flag Coverage Δ
unittests 56.51% <16.66%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
...rc/modules/farm/v2/services/farm.v2.abi.service.ts 28.08% <0.00%> (ø)
...services/userEnergy/user.energy.compute.service.ts 46.42% <25.00%> (-1.08%) ⬇️

... and 5 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dragos-rebegea dragos-rebegea deleted the MEX-362 branch August 30, 2023 08:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant