Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SERVICES-1828] nestjs-metrics integration #1176

Conversation

claudiulataretu
Copy link
Collaborator

@claudiulataretu claudiulataretu commented Sep 7, 2023

Reasoning

  • integrate sdk-nestjs-monitoring

Proposed Changes

  • remove base metrics from metrics collector
  • use base metrics from sdk-nestjs-monitoring

How to test

GET http://localhost:4001/metrics
  • should return both base and specialized metrics

@codecov
Copy link

codecov bot commented Sep 7, 2023

Codecov Report

❗ No coverage uploaded for pull request base (feat/nestjs-sdk-integration@408fb92). Click here to learn what that means.
Patch has no changes to coverable lines.

Additional details and impacted files
@@                      Coverage Diff                       @@
##             feat/nestjs-sdk-integration    #1176   +/-   ##
==============================================================
  Coverage                               ?   56.65%           
==============================================================
  Files                                  ?      238           
  Lines                                  ?     7966           
  Branches                               ?      536           
==============================================================
  Hits                                   ?     4513           
  Misses                                 ?     2996           
  Partials                               ?      457           
Flag Coverage Δ
unittests 56.65% <0.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.

📢 Have feedback on the report? Share it here.

@claudiulataretu claudiulataretu merged commit 54ec4f8 into feat/nestjs-sdk-integration Sep 11, 2023
3 checks passed
@claudiulataretu claudiulataretu deleted the SERVICES-1828-monitoring-module-integration branch September 11, 2023 11:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants