Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SERVICES-1832] fix logs processor lastProcessedTimestamp #1188

Conversation

claudiulataretu
Copy link
Collaborator

Reasoning

  • wrong check for cached value

Proposed Changes

  • check for undefined for values cached

How to test

  • N/A

@codecov
Copy link

codecov bot commented Sep 18, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (02882e6) 56.15% compared to head (94d20d5) 56.15%.
Report is 1 commits behind head on feat/nestjs-sdk-integration.

Additional details and impacted files
@@                     Coverage Diff                      @@
##           feat/nestjs-sdk-integration    #1188   +/-   ##
============================================================
  Coverage                        56.15%   56.15%           
============================================================
  Files                              235      235           
  Lines                             7818     7818           
  Branches                           519      519           
============================================================
  Hits                              4390     4390           
  Misses                            2986     2986           
  Partials                           442      442           
Flag Coverage Δ
unittests 56.15% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@claudiulataretu claudiulataretu merged commit 398ffc3 into feat/nestjs-sdk-integration Sep 18, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants