Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MEX-410] dual yield position from lp token #1265

Conversation

claudiulataretu
Copy link
Collaborator

Reasoning

  • position creator SC accepts lp token to convert it into a dual yield position

Proposed Changes

  • update createDualFarmPositionSingleToken to create transaction from lp token

How to test

query CreateDualFarmPositionSingleToken {
	createDualFarmPositionSingleToken(
		dualFarmAddress: <dual_farm_address>,
		payments: [{
			tokenID: <lp_token_id>,
			nonce: 0,
			amount: <amount>
		}],
		tolerance: 0.01
	) {
		receiver
		data
	}
}
  • query should return transaction if valid lp token is used

Copy link

codecov bot commented Jan 22, 2024

Codecov Report

Attention: 7 lines in your changes are missing coverage. Please review.

Comparison is base (6099d15) 56.67% compared to head (388d07c) 56.70%.
Report is 5 commits behind head on feat/xexchange-v3.

Files Patch % Lines
...n-creator/services/position.creator.transaction.ts 78.57% 0 Missing and 6 partials ⚠️
...ition-creator/services/position.creator.compute.ts 66.66% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@                  Coverage Diff                  @@
##           feat/xexchange-v3    #1265      +/-   ##
=====================================================
+ Coverage              56.67%   56.70%   +0.02%     
=====================================================
  Files                    242      242              
  Lines                   8587     8599      +12     
  Branches                 612      615       +3     
=====================================================
+ Hits                    4867     4876       +9     
+ Misses                  3188     3185       -3     
- Partials                 532      538       +6     
Flag Coverage Δ
unittests 56.70% <77.41%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mad2sm0key mad2sm0key self-requested a review January 23, 2024 07:22
@claudiulataretu claudiulataretu merged commit d5539ec into feat/xexchange-v3 Jan 23, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants