[SERVICES-2569] Caching improvements for pairs #1458
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- bulk getter methods for pairs state, fee state, locked value, deployed at, trades count, hasFarms, hasDualFarms
- use bulk getter methods inside pair abi and compute dataloaders
mad2sm0key
changed the title
cfaur09
approved these changes
Sep 11, 2024
bogdan-rosianu
approved these changes
Sep 11, 2024
claudiulataretu
approved these changes
Sep 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reasoning
pairsandfilteredPairsqueries rely on Promise.all() for getting field data needed for sorting and filtering. Although most data is coming from cache, this still causes degradation in performance due to the large number of pairsProposed Changes
lpTokenID,state,feeState,lockedValueUSD,deployedAt,tradesCount,hasFarms,hasDualFarmsHow to test