Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SERVICES-2577] Staking farms filter by depleted rewards #1461

Conversation

mad2sm0key
Copy link
Contributor

Reasoning

  • The front-end needs a way to filter out staking farms with depleted rewards on the filteredStakingFarms query

Proposed Changes

  • add rewardsDepleted boolean filter to filteredStakingFarms query

How to test

  • the query below should only return staking farms with remaining rewards
query {
  filteredStakingFarms(
    filters:{
      rewardsDepleted: false
    }
    pagination:{
      first:1
    }
    sorting: {
      sortField: TVL
      sortOrder: DESC
    }
  ) {
    edges {
      cursor
      node {
        address
        apr
        farmingToken {
          identifier
        }
        farmToken {
          ticker
        }
      }
    }
    pageData {
      count
      limit
      offset
    }
  }
}

gabrielmatei
gabrielmatei previously approved these changes Sep 11, 2024
- rename filter field
cfaur09
cfaur09 previously approved these changes Sep 11, 2024
src/modules/staking/services/staking.service.ts Outdated Show resolved Hide resolved
src/modules/staking/models/staking.args.ts Outdated Show resolved Hide resolved
- move bulk getter methods to staking.abi service
- rename filter field
@mad2sm0key mad2sm0key merged commit e4ba03b into feat/xexchange-v3 Sep 11, 2024
1 check failed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants